On 27 Aug 2011, at 09:21, Navdeep Parhar wrote: >> (3) options BREAK_TO_DEBUGGER and options ALT_BREAK_TO_DEBUGGER continue >> to behave as before -- only now instead of compiling in >> break-to-debugger support, they change the default values of the >> above sysctls to enable those features by default. Current kernel >> configurations should, therefore, continue to behave as expected. > > Shouldn't opt_comconsole.h be included in subr_kdb.c for this part to > actually work?
Yes, you're right. We should almost certainly garbage collect opt_comconsole.h entirely at this point, moving the break options into opt_kdb.h as well. It also looks like I missed one of the ARM uart implementations during my walk of the tree as well. I'll send a follow-up patch to re@ today to refine this change further. (The dcons Makefile also does something odd, in that it sets #define KDB in its own opt_kdb.h when built independently of the kernel, but actually, that's now #define KDB goes for the base kernel -- it goes in opt_global.h. I'll need to ponder what the right thing to do there is, and whether it's worth fixing at this point.) Robert_______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
