Author: jhb
Date: Tue Oct  6 18:13:15 2020
New Revision: 366494
URL: https://svnweb.freebsd.org/changeset/base/366494

Log:
  Don't permit DRM buffer mappings to be upgraded to executable.
  
  Reviewed by:  kib
  MFC after:    1 month
  Sponsored by: DARPA
  Differential Revision:        https://reviews.freebsd.org/D26697

Modified:
  head/sys/dev/drm2/drm_bufs.c

Modified: head/sys/dev/drm2/drm_bufs.c
==============================================================================
--- head/sys/dev/drm2/drm_bufs.c        Tue Oct  6 18:07:52 2020        
(r366493)
+++ head/sys/dev/drm2/drm_bufs.c        Tue Oct  6 18:13:15 2020        
(r366494)
@@ -1635,14 +1635,12 @@ int drm_mapbufs(struct drm_device *dev, void *data,
                                goto done;
                        }
                        retcode = vm_mmap(&vms->vm_map, &virtual, map->size,
-                           VM_PROT_READ | VM_PROT_WRITE, VM_PROT_ALL,
-                           MAP_SHARED | MAP_NOSYNC, OBJT_DEVICE,
-                           file_priv->minor->device, token);
+                           VM_PROT_RW, VM_PROT_RW, MAP_SHARED | MAP_NOSYNC,
+                           OBJT_DEVICE, file_priv->minor->device, token);
                } else {
                        retcode = vm_mmap(&vms->vm_map, &virtual, 
dma->byte_count,
-                           VM_PROT_READ | VM_PROT_WRITE, VM_PROT_ALL,
-                           MAP_SHARED | MAP_NOSYNC, OBJT_DEVICE,
-                           file_priv->minor->device, 0);
+                           VM_PROT_RW, VM_PROT_RW, MAP_SHARED | MAP_NOSYNC,
+                           OBJT_DEVICE, file_priv->minor->device, 0);
                }
                if (retcode) {
                        /* Real error */
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to