On 9/2/20 12:09 PM, Mark Johnston wrote: > On Wed, Sep 02, 2020 at 11:43:56AM -0700, John Baldwin wrote: >> On 9/2/20 11:17 AM, Mark Johnston wrote: >>> Author: markj >>> Date: Wed Sep 2 18:17:08 2020 >>> New Revision: 365268 >>> URL: https://svnweb.freebsd.org/changeset/base/365268 >>> >>> Log: >>> Add sysctl(8) formatting for hw.pagesizes. >>> >>> - Change the type of hw.pagesizes to OPAQUE, since it returns an array. >>> - Modify the handler to only truncate the returned length if the caller >>> supplied an output buffer. This allows use of the trick of passing a >>> NULL output buffer to fetch the output size, while preserving >>> compatibility if MAXPAGESIZES is increased. >>> - Add a "S,pagesize" formatter to sysctl(8). >> >> Doesn't sysctl(8) handle scalar types that are arrays? That is, couldn't >> this change just be the change to not truncate 'len' without needing to make >> it opaque and needing a custom printer, etc.? > > I think you are right. I didn't know sysctl(8) could do that.
I only know from dealing with it in the past. kern.cp_time is an array for example. In the past year or so I updated sysctl to permit setting an array of values (for dev.t6nex.0.toe.rx_tls_ports which takes a list of TCP ports to enable TOE TLS on). -- John Baldwin _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
