On Wed, Mar 18, 2020 at 12:29:24PM +0900, Hiroki Sato wrote: > Brooks Davis <bro...@freebsd.org> wrote > in <202003171817.02hihwdy035...@repo.freebsd.org>: > > br> Author: brooks > br> Date: Tue Mar 17 18:17:32 2020 > br> New Revision: 359046 > br> URL: https://svnweb.freebsd.org/changeset/base/359046 > br> > br> Log: > br> Support SUBDIR.${MK_FOO}.${MK_BAR} expresssions. > br> > br> This allows simplification of Makefiles where some SUBDIR entries depend > br> on two things (e.g. something that depends on C++ and some other knob). > > Just my two cents, but SUBDIR.${MK_FOO:M${MK_BAR}:M${MK_BAZ}}= dir > should do the trick. I am not sure how many variables we need to > support in practice, adding ".yes.yes..." in bsd.subdir.mk looks less > flexible to me.
IMO that's lousy from a readability perspective. It's remotely conceivable that supporting three variables might make sense, but more seems vanishingly unlikely and even so, it's trivial to add more cases. -- Brooks
signature.asc
Description: PGP signature
