On 2020-01-15 07:10, Gleb Smirnoff wrote:
I really want to reverse the argument order of epoch_call() as well.
The current order is really backwards:

      void
      epoch_call(epoch_t epoch, epoch_context_t ctx,
          void (*callback)(epoch_context_t));

Suggested declaration is:

      void
      epoch_call(epoch_t epoch, epoch_context_t ctx,
         void (*callback)(epoch_context_t));

Hi,

I think he meant to put the ctx argument last. Look at how the function is implemented to see if that makes any sense, I.E. how arguments are optimised.

>       epoch_call(epoch_t epoch, epoch_context_t ctx,
>          void (*callback)(epoch_context_t));

Is this *want* just because of "function, argument" is better than "argument, function" ?

--HPS
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to