> On 13. Jan 2020, at 20:31, Ian Lepore <i...@freebsd.org> wrote: > > On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Mon Jan 13 18:22:54 2020 >> New Revision: 356693 >> URL: https://svnweb.freebsd.org/changeset/base/356693 >> >> Log: >> loader: allocate properly aligned buffer for network packet >> >> Use memalign(4, size) to ensure we have properly aligned buffer. >> >> MFC after: 2 weeks >> >> Modified: >> head/stand/efi/libefi/efinet.c >> head/stand/i386/libi386/pxe.c >> head/stand/libofw/ofw_net.c >> head/stand/uboot/lib/net.c >> > > The malloc implementation in libstand already g'tees minimum alignment > of 16 bytes on most arches, 64 bytes on arches that use u-boot (see > libsa/zalloc_defs.h). So how does this change anything? > Hi! Well, given the amount of knobs etc, it does not hurt to be explicit, does it? rgds, toomas _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib
Toomas Soome via svn-src-head Mon, 13 Jan 2020 10:44:24 -0800
- svn commit: r356693 - in head/stand: efi/lib... Toomas Soome
- Re: svn commit: r356693 - in head/stand... Ian Lepore
- Re: svn commit: r356693 - in head/s... Toomas Soome via svn-src-head
- Re: svn commit: r356693 - in he... Ian Lepore
- Re: svn commit: r356693 - i... Toomas Soome via svn-src-head