Thanks Warner for noticing and fixing this.

I've sent the patch upstream to hopefully be addressed there as well:

https://github.com/facebook/zstd/pull/1713

Best,
Conrad

On Thu, Aug 8, 2019 at 1:09 PM Warner Losh <i...@freebsd.org> wrote:
>
> Author: imp
> Date: Thu Aug  8 20:09:36 2019
> New Revision: 350778
> URL: https://svnweb.freebsd.org/changeset/base/350778
>
> Log:
>   Stopgap fix for gcc platforms.
>
>   Our in-tree gcc doesn't have a no-tree-vectorize optimization knob, so we 
> get a
>   warning that it's unused. This causes the build to fail on all our gcc 
> platforms.
>   Add a quick version check as a stop-gap measure to get CI building again.
>
> Modified:
>   head/sys/contrib/zstd/lib/common/compiler.h
>
> Modified: head/sys/contrib/zstd/lib/common/compiler.h
> ==============================================================================
> --- head/sys/contrib/zstd/lib/common/compiler.h Thu Aug  8 20:07:38 2019      
>   (r350777)
> +++ head/sys/contrib/zstd/lib/common/compiler.h Thu Aug  8 20:09:36 2019      
>   (r350778)
> @@ -128,7 +128,7 @@
>  }
>
>  /* vectorization */
> -#if !defined(__clang__) && defined(__GNUC__)
> +#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ > 5
>  #  define DONT_VECTORIZE __attribute__((optimize("no-tree-vectorize")))
>  #else
>  #  define DONT_VECTORIZE
>
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to