Author: markj
Date: Tue Jul 30 22:41:25 2019
New Revision: 350458
URL: https://svnweb.freebsd.org/changeset/base/350458

Log:
  Use VNASSERT() in checked VOP wrappers.
  
  Reviewed by:  kib
  MFC after:    3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:        https://reviews.freebsd.org/D21120

Modified:
  head/sys/sys/vnode.h

Modified: head/sys/sys/vnode.h
==============================================================================
--- head/sys/sys/vnode.h        Tue Jul 30 20:58:56 2019        (r350457)
+++ head/sys/sys/vnode.h        Tue Jul 30 22:41:25 2019        (r350458)
@@ -844,27 +844,30 @@ void      vop_rename_fail(struct vop_rename_args *ap);
 
 #define VOP_LOCK(vp, flags) VOP_LOCK1(vp, flags, __FILE__, __LINE__)
 
-#ifdef INVARIANTS
+#ifdef INVARIANTS
 #define        VOP_ADD_WRITECOUNT_CHECKED(vp, cnt)                             
\
 do {                                                                   \
        int error_;                                                     \
                                                                        \
        error_ = VOP_ADD_WRITECOUNT((vp), (cnt));                       \
-       MPASS(error_ == 0);                                             \
+       VNASSERT(error_ == 0, (vp), ("VOP_ADD_WRITECOUNT returned %d",  \
+           error_));                                                   \
 } while (0)
 #define        VOP_SET_TEXT_CHECKED(vp)                                        
\
 do {                                                                   \
        int error_;                                                     \
                                                                        \
        error_ = VOP_SET_TEXT((vp));                                    \
-       MPASS(error_ == 0);                                             \
+       VNASSERT(error_ == 0, (vp), ("VOP_SET_TEXT returned %d",        \
+           error_));                                                   \
 } while (0)
 #define        VOP_UNSET_TEXT_CHECKED(vp)                                      
\
 do {                                                                   \
        int error_;                                                     \
                                                                        \
        error_ = VOP_UNSET_TEXT((vp));                                  \
-       MPASS(error_ == 0);                                             \
+       VNASSERT(error_ == 0, (vp), ("VOP_UNSET_TEXT returned %d",      \
+           error_));                                                   \
 } while (0)
 #else
 #define        VOP_ADD_WRITECOUNT_CHECKED(vp, cnt)     
VOP_ADD_WRITECOUNT((vp), (cnt))
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to