On 2019-06-03 17:19, Andriy Gapon wrote:
On 03/06/2019 17:52, Ian Lepore wrote:
Please don't. We still have a situation where nobody has shown a
runtime failure at all. This build failure could be fixed by simply
defining a do-nothing iicbus_set_nostop() function if a quick fix is
needed.
Well, I am quite certain that the run-time failure will follow after the build
time failure is fixed.
Putting this nostop concept into code that is shared by many drivers is
an abomination. We have exactly one driver that needs this
functionality, so the right fix is to implement it wholly within that
one driver. I'll put together a diff for that.
That's true that we have just one such driver.
At the same time, the "no stop" (or rather, repeated start) behavior makes more
sense. If stop+start between transfers are needed then that can be done with
multiple calls to iicbus_transfer. If multiple messages are given to
iicbus_transfer, then it's reasonable to assume that a repeated started is
wanted between them. But it would be a big change to review and, if needed, fix
or tidy up all code that uses iicbus_transfer. So, iicbus_set_nostop() could be
just a small step towards the bigger goal.
But I really don't have a strong opinion.
Fixing drm2 directly is just as good for me as iicbus_set_nostop.
Hi!
From my perspective, either solution is fine, as long as the drm-legacy
drivers keep on working, and I get some help fixing the issue.
Is there any way we can revert this change while we're discussing the
best solution to this?
Regards
--
Niclas Zeising
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
