Author: hselasky
Date: Wed May 8 10:53:25 2019
New Revision: 347295
URL: https://svnweb.freebsd.org/changeset/base/347295
Log:
Let rx_out_of_buffer be a 32-bit counter in mlx5en(4).
This fixes counting issues when the firmware resets the counter during
allocation of the counter set where the counter belongs.
MFC after: 3 days
Sponsored by: Mellanox Technologies
Modified:
head/sys/dev/mlx5/mlx5_en/en.h
head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
Modified: head/sys/dev/mlx5/mlx5_en/en.h
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/en.h Wed May 8 10:53:01 2019
(r347294)
+++ head/sys/dev/mlx5/mlx5_en/en.h Wed May 8 10:53:25 2019
(r347295)
@@ -196,7 +196,6 @@ struct mlx5e_vport_stats {
struct sysctl_ctx_list ctx;
u64 arg [0];
MLX5E_VPORT_STATS(MLX5E_STATS_VAR)
- u32 rx_out_of_buffer_prev;
};
#define MLX5E_PPORT_IEEE802_3_STATS(m)
\
Modified: head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c Wed May 8 10:53:01 2019
(r347294)
+++ head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c Wed May 8 10:53:25 2019
(r347295)
@@ -593,10 +593,7 @@ mlx5e_update_stats_locked(struct mlx5e_priv *priv)
if (test_bit(MLX5E_STATE_OPENED, &priv->state) != 0 &&
mlx5_vport_query_out_of_rx_buffer(mdev, priv->counter_set_id,
&rx_out_of_buffer) == 0) {
- /* accumulate difference into a 64-bit counter */
- s->rx_out_of_buffer += (u64)(u32)(rx_out_of_buffer -
- s->rx_out_of_buffer_prev);
- s->rx_out_of_buffer_prev = rx_out_of_buffer;
+ s->rx_out_of_buffer = rx_out_of_buffer;
}
/* get port statistics */
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
