In message <a69cf582-abc7-aff9-41c7-ed2a9e13e...@gandi.net>, Fatih Acar writes: > This is a multi-part message in MIME format. > --------------6A54CE5B28D823DCB8C41577 > Content-Type: text/plain; charset=utf-8 > Content-Transfer-Encoding: 8bit > > On 2/26/19 5:36 PM, Cy Schubert wrote: > > On February 26, 2019 8:11:31 AM PST, Baptiste Daroussin <b...@freebsd.org> > wrote: > >> On Tue, Feb 26, 2019 at 05:04:11PM +0100, Baptiste Daroussin wrote: > >>> On Tue, Feb 26, 2019 at 07:48:27AM -0800, Cy Schubert wrote: > >>>> On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > >> <b...@freebsd.org> wrote: > >>>>> Author: bapt > >>>>> Date: Tue Feb 26 08:18:34 2019 > >>>>> New Revision: 344569 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/344569 > >>>>> > >>>>> Log: > >>>>> Implement parallel mounting for ZFS filesystem > >>>>> > >>>>> It was first implemented on Illumos and then ported to ZoL. > >>>>> This patch is a port to FreeBSD of the ZoL version. > >>>>> This patch also includes a fix for a race condition that was > >> amended > >>>>> > >>>>> With such patch Delphix has seen a huge decrease in latency of the > >>>>> mount phase > >>>>> (https://github.com/openzfs/openzfs/commit/a3f0e2b569 for > >> details). > >>>>> With that current change Gandi has measured improvments that are > >> on par > >>>>> with > >>>>> those reported by Delphix. > >>>>> > >>>>> Zol commits incorporated: > >>>> > >>> https://github.com/zfsonlinux/zfs/commit/a10d50f999511d304f910852c7825c70 > c9c9e303 > >>>> > >>> https://github.com/zfsonlinux/zfs/commit/e63ac16d25fbe991a356489c86d40775 > 67dfea21 > >>>>> > >>>>> Reviewed by: avg, sef > >>>>> Approved by: avg, sef > >>>>> Obtained from: ZoL > >>>>> MFC after: 1 month > >>>>> Relnotes: yes > >>>>> Sponsored by: Gandi.net > >>>>> Differential Revision: https://reviews.freebsd.org/D19098 > >>>>> > >>>>> Modified: > >>>>> head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_impl.h > >>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c > >>>>> > >>>>> Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c > >>>> > >>> ========================================================================= > ===== [...] > >>>>> > >>>> > >>>> This broke my systems, many filesystems fail to mount causing > >> nullfs late mounts to fail. No details now until tonight. > >>>> > >>>> Suggest we back this out until it is properly tested. > >>>> > >>> > >>> What fails to mount? what message? can you provide Gandi folks more > >> informations > >>> so they can fix? > >>> > >>> I will revert if we cannot have a quick fix but let s give them a > >> chance to fix > >>> first. > >>> > >> With the proper email in CC there is a better chance to reach at them > >> :) > >> > >> Best regards, > >> Bapt > > > > Sorry about that. I'm terribly frustrated as this broke my mail gateway, ha > ving to fix it using juiceSSH on my phone on the bus. Ssh on the phone makes > for a very grumpy Cy. > > > > I did bring my personal laptop to work, so I'll try to help out testing thi > s at noon here and maybe look at it more. I'll help out any way I can. > > > > > > Sorry about all this... > Could you try the attached patch, it should fix the issue. I don't > understand how this regression happened, it's not present in ZoL... > I'll check with Jack who worked on this when he's back from PTO. > > Thanks. > > -- > Fatih ACAR > Gandi > fatih.a...@gandi.net > > --------------6A54CE5B28D823DCB8C41577 > Content-Type: text/x-patch; > name="mount.patch" > Content-Transfer-Encoding: quoted-printable > Content-Disposition: attachment; > filename="mount.patch" > > Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (revision 3= > 44590) > +++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (working co= > py) > @@ -1260,11 +1260,11 @@ > if (*a =3D=3D '\0') > return (-1); > if (*b =3D=3D '\0') > - return (-1); > + return (1); > if (*a =3D=3D '/') > return (-1); > if (*b =3D=3D '/') > - return (-1); > + return (1); > return (*a < *b ? -1 : *a > *b); > } > =20 >
Thanks. This fixes this particular issue. There is one other minor issues that should also be addressed. The mount message at boot previously displayed: Mounting ZFS filesystems: (44/159)^H^H^H^H^H^H^H^H(106/159)^H^H^H^H^H^H^H^H^H(15 9/159)^M Now it displays: (null): (44/159)^H^H^H^H^H^H^H^H(106/159)^H^H^H^H^H^H^H^H^H(159/159)^M -- Cheers, Cy Schubert <cy.schub...@cschubert.com> FreeBSD UNIX: <c...@freebsd.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
