> On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > > > Author: lme (ports committer) > > > Date: Fri Jan 11 15:52:09 2019 > > > New Revision: 342945 > > > URL: https://svnweb.freebsd.org/changeset/base/342945 > > > +.Nm > > > +utility first appeared in > > > +.Fx 12.1 . > > > +.Sh AUTHORS > > > +.An Dirk Engling Aq Mt erdge...@erdgeist.org > > > +.Sh THANKS TO > > > +Lars Engels and Warren Block for suggestions, help, and testing. > > > > The contents of this file appear twice???? > > Yes, sorry. My fault. Bapt already fixed this in r342947.
It was in the differential that way too and no one noticed :-( > > > > > Added: head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh > > > ============================================================================== > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/usr.sbin/bluetooth/bluetooth-config/bluetooth-config.sh Fri Jan > > > 11 15:52:09 2019 (r342945) > > > @@ -0,0 +1,275 @@ > > > +#!/bin/sh > > > +#- > > > +# Copyleft 2019 Dirk Engling > > > > That implies the GPL, would you be willing to change it to > > what it appears your actually asserting, a Copyright, please. > > I just asked Dirk if I can change this to "Copyright". It was a mistake > on his side and he agrees to the change. Great, thanks. > > > > > +# > > > +# This script is released under the beerware license. > > > > Incomplete and none deterministic license reference, > > this needs to be corrected in some way, preferable > > with the text of the beerware license so there is > > no doubt as to what applies. > > I'll add the Beerware header. Again thanks. > > > +# After function definitions, main() can use them > > > +main "$@" > > > + > > > +exit > > > + > > > +# TODO > > > +# * If device is a keyboard, offer a text entry test field and if it does > > > +# not succeed, leave some clues for debugging (i.e. if the node > > > responds > > > +# to pings, maybe switch keyboard on/off, etc) > > > +# * Same if device is a mouse, i.e. hexdump /dev/sysmouse. > > > +# * If device offers DUN profiles, ask the user if an entry in > > > +# /etc/ppp/ppp.conf should be created > > > +# * If OPUSH or SPP is offered, refer to the respective man pages to give > > > +# some clues how to continue > > > > > > > > > > The style of this .sh does not match the normal style of > > such things in base, especially with respect to long lines > > and indentation. > > Do we have a style guide for shell scripts in base? How should > indentation look like? Not that I can locate, but I can state that almost all of the base code uses tab indenting and limited to 80 column widths, independent of c, sh, make, etc. -- Rod Grimes rgri...@freebsd.org _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
