Marcelo Araujo wrote this message on Thu, Aug 16, 2018 at 06:31 +0000:
> Author: araujo
> Date: Thu Aug 16 06:31:54 2018
> New Revision: 337887
> URL: https://svnweb.freebsd.org/changeset/base/337887
>
> Log:
> Add a comment explaining how the PSN works and why there is no need for
> a null terminator. Also mark CID 1394825 as intentional.
>
> Reported by: Coverity
> CID: 1394825
> MFC after: 1 week
> Sponsored by: iXsystems Inc.
>
> Modified:
> head/usr.sbin/bhyve/pci_nvme.c
>
> Modified: head/usr.sbin/bhyve/pci_nvme.c
> ==============================================================================
> --- head/usr.sbin/bhyve/pci_nvme.c Thu Aug 16 06:20:25 2018
> (r337886)
> +++ head/usr.sbin/bhyve/pci_nvme.c Thu Aug 16 06:31:54 2018
> (r337887)
> @@ -1714,6 +1714,11 @@ pci_nvme_parse_opts(struct pci_nvme_softc *sc, char *o
[...]
> memset(sc->ctrldata.sn, 0, sizeof(sc->ctrldata.sn));
> strncpy(sc->ctrldata.sn, config,
> sizeof(sc->ctrldata.sn));
This memset is unneeded, as strncpy will write NUL bytes to fill out
the buffer:
If src is less than len characters long, the remainder of
dst is filled with `\0' characters.
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
