I had two functional changes in mind for after this part (which I hoped would be non controversial) that you would be included on the review. Markj pointed me at the related D15592. I’m not sure that approach was the correct one and hope to continue discussion there. Once that’s reached consensus, I may need to revisit my subsequent change. If it ends up that ultimately this particular patch isn’t used, backing it out is trivial. Until then, it’s pretty harmless.
Thanks, Conrad On Thu, Aug 9, 2018 at 2:56 PM Scott Long <sco...@samsco.org> wrote: > > > > On Aug 9, 2018, at 3:53 PM, Conrad Meyer <c...@freebsd.org> wrote: > > > > Author: cem > > Date: Thu Aug 9 21:53:32 2018 > > New Revision: 337554 > > URL: https://svnweb.freebsd.org/changeset/base/337554 > > > > Log: > > cam(4): Add an xpt-neutral flag indicating a valid panic CCB > > > > No functional change. > > > > Note that this change is careful to set the CCB header xflags after > > foo_fill_bar() routines, which generally zero existing flags. An > earlier > > version of this patch mistakenly set the flag before the fill routines. > > > > Submitted by: Scott Ferris <sferris AT isilon.com>, jhibbits@ > > Reviewed by: bdrewery@, markj@, and non-committer FreeBSD contributor > Anton Rang > > Sponsored by: Dell EMC Isilon > > What’s the purpose of this flag? I see it gets set in plenty of places, > but never checked. > > Scott > > _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
