On Fri, Jul 06, 2018 at 09:24:22AM -0700, John Baldwin wrote: > On 7/6/18 3:03 AM, Brooks Davis wrote: > > Author: brooks > > Date: Fri Jul 6 10:03:33 2018 > > New Revision: 336023 > > URL: https://svnweb.freebsd.org/changeset/base/336023 > > > > Log: > > Correct breakage on 32-bit platforms from r335979. > > Do we still need the kvaddr_t casts after the uintptr_t cast? Are those > only required for CHERI (and perhaps if we change the default of how > uintptr_t gets converted to an int to default to the vaddr we may find > we won't need them at all even on CHERI)?
The kvaddr_t casts are probably unnecessicary on FreeBSD. I'll look at removing them. The uintptr_t casts are currently harmless on CHERI in hybrid mode and broken in pure-capbiltiy mode until we change uintptr_t cast behavior. -- Brooks
signature.asc
Description: PGP signature
