On 07/02/18 21:48, Matt Macy wrote:
Author: mmacy
Date: Mon Jul 2 19:48:38 2018
New Revision: 335873
URL:https://svnweb.freebsd.org/changeset/base/335873
Log:
inline atomics and allow tied modules to inline locks
- inline atomics in modules on i386 and amd64 (they were always
inline on other arches)
- allow modules to opt in to inlining locks by specifying
MODULE_TIED=1 in the makefile
Reviewed by: kib
Sponsored by: Limelight Networks
Differential Revision:https://reviews.freebsd.org/D16079
Hi,
This change breaks all atomic usage in drm-next-kmod even after r335913.
The problem is simply that SMP is not defined at all for KLD's so all
non-kernel atomic usage is with MPLOCKED empty!
/*
* For userland, always use lock prefixes so that the binaries will run
* on both SMP and !SMP systems.
*/
#if defined(SMP) || !defined(_KERNEL)
#define MPLOCKED "lock ; "
#else
#define MPLOCKED
#endif
Should the check above be:
#if defined(SMP) || !defined(_KERNEL) || defined(KLD_MODULE)
--HPS
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
