On Fri, Dec 10, 2010 at 11:07 AM, Pawel Worach <pawel.wor...@gmail.com> wrote: > On Dec 8, 2010, at 15:30, Shteryana Shopova wrote: >> Author: syrinx >> Date: Wed Dec 8 14:30:25 2010 >> New Revision: 216295 >> URL: http://svn.freebsd.org/changeset/base/216295 >> >> Log: >> Add bsnmpd(1)'s SNMP client tools (including SNMPv3 support) to the base >> system. >> >> Sponsored by: The FreeBSD Foundation (the SNMPv3 bits), Google Summer of >> Code 2005 >> Reviewed by: philip@ (mostly), bz@ (earlier version based on p4 ch124545) >> Approved by: philip@ >> >> Added: >> head/usr.sbin/bsnmpd/tools/libbsnmptools/Makefile (contents, props >> changed) > > > Hi, > > In bsnmpd/tools/libbsnmptools/Makefile you set CFLAGS+= -g -Wall -Werror
And it's just plain wrong in the first place; if you want to specify -g, etc please use DEBUG_FLAGS. > this breaks the build with clang even with NO_WERROR=1 set, you probably want > so this instead: > > WARNS?= <level> > > ps. > The warnings with clang are: > /data/buildslave/freebsd-clang-amd64/src-freebsd/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c:620:50: > error: comparison of unsigned expression < 0 is always false > [-Wtautological-compare] > snmp_client.cengine, SNMP_ENGINE_ID_SIZ)) < 0) { > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > /data/buildslave/freebsd-clang-amd64/src-freebsd/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c:658:38: > error: comparison of unsigned expression < 0 is always false > [-Wtautological-compare] > if (snmp_client.engine.engine_len < 0) { > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ Thanks, -Garrett _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"