On 3 December 2010 13:46, John Baldwin <j...@freebsd.org> wrote: > On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: >> On Fri, 3 Dec 2010 20:45:12 +1100 (EST) >> Bruce Evans <b...@optusnet.com.au> wrote: >> >> > KASSERT() in little inline functions gives a lot of bloat for such an >> > unlikely error. Stupid callers can still pass any garbage count >> > except 0. >> >> Yes, this catches a specific case that hps raised a few years ago: >> sending zero-length packets/frames would fail by causing the system to >> hang. Should we just document the restriction in the man page and not >> try and prevent it at runtime? > > Documenting it is probably sufficient.
I'd say it depends on if the "specific case that hps raised a few years ago" sentence part refers to an actual problem; i.e. did it happen in practice? If yes, leaving KASSERTs looks like the best option. _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
