Author: yongari
Date: Tue Aug 31 19:59:18 2010
New Revision: 212069
URL: http://svn.freebsd.org/changeset/base/212069
Log:
bge_txeof() already checks whether it has to free transmitted mbufs
or not by comparing reported TX consumer index with saved index. So
remove unnecessary check done after freeing transmitted mbufs.
While I'm here nuke unnecessary variable initializations.
Modified:
head/sys/dev/bge/if_bge.c
Modified: head/sys/dev/bge/if_bge.c
==============================================================================
--- head/sys/dev/bge/if_bge.c Tue Aug 31 19:26:29 2010 (r212068)
+++ head/sys/dev/bge/if_bge.c Tue Aug 31 19:59:18 2010 (r212069)
@@ -3394,7 +3394,7 @@ bge_rxeof(struct bge_softc *sc, uint16_t
static void
bge_txeof(struct bge_softc *sc, uint16_t tx_cons)
{
- struct bge_tx_bd *cur_tx = NULL;
+ struct bge_tx_bd *cur_tx;
struct ifnet *ifp;
BGE_LOCK_ASSERT(sc);
@@ -3412,7 +3412,7 @@ bge_txeof(struct bge_softc *sc, uint16_t
* frames that have been sent.
*/
while (sc->bge_tx_saved_considx != tx_cons) {
- uint32_t idx = 0;
+ uint32_t idx;
idx = sc->bge_tx_saved_considx;
cur_tx = &sc->bge_ldata.bge_tx_ring[idx];
@@ -3431,8 +3431,7 @@ bge_txeof(struct bge_softc *sc, uint16_t
BGE_INC(sc->bge_tx_saved_considx, BGE_TX_RING_CNT);
}
- if (cur_tx != NULL)
- ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
+ ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
if (sc->bge_txcnt == 0)
sc->bge_timer = 0;
}
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
