Em 2010.07.25. 22:17, Doug Barton escreveu:
On Sun, 25 Jul 2010, Gabor Kovesdan wrote:
Author: gabor
Date: Sun Jul 25 18:57:48 2010
New Revision: 210479
URL: http://svn.freebsd.org/changeset/base/210479
Log:
- Fix -l and -L by really surpressing output and just showing filenames
Submitted by: swel...@gmail.com
.... and dougb. :) (It was part of the patch I sent on Friday.)
I had to merge your patch with another one that I had in my working copy
and I didn't catch this part. Sorry for that, it was my mistake.
And not to pile on, but regression testing should have caught this.
First by you, and if all else fails, by your mentor. At very least the
thought process could have gone something like: "Let's see, the patch
that I/Gabor generated to fix this problem is different than the one
Doug generated. Now Doug is not a _complete_ moron, so let's take a
careful look at this change and see if it really does what we think it
should do."
Nobody told that you were a moron and I did run regression testing, the
test suite that GNU grep has. It passes a good number of them and some
only fail because of their non-standard regexes and GNU-specific
idiotism, like whether gnu --help contains the "Report bugs to
<bug-gnu-ut...@gnu.org>." . Even the GNU version that we have in base
fails on 6 tests of latest GNU grep's test suite. Regression testing is
good but sometimes real users are necessary to axe out bugs and I think
we are going into the right direction and I still don't consider
importing BSD grep a mistake. Bugs might appear but as you can see I'm
trying to fix them asap and grep is improving in this way. Although grep
seems to be a little silly utility on the top of the regex library, it's
quite complex and it involves a lot of things, like the GNU regex
syntax. That's why it took so long to get it to base. There were 4
exp-runs and varios CFTs but these bugs haven't been found so far so I
think this broader exposure was quite a good decision.
Aside from the fact that despite its innocuous appearance grep really
is an important tool; I've expressed frustration in the past that
mentors are not in place to simply rubber stamp things. Mentors serve
at least 2 critical functions; to introduce mentees to "The FreeBSD
Culture," and to sanity-check changes. No matter how technically
competent the mentee is (and obviously Gabor is a sharp guy) both of
these functions are critical to their successful introduction into the
wonderful world of DougBS^W I mean, uh, FreeBSD. :)
My mentor really helped a lot and made lots of suggestions to improve
the code but he's also a human being, he can't see everything either. :)
These bugs survived lots of testing and review so it's not a surprise
that he didn't found them either. Let's not flame about it any more just
concentrate on bugfixing. Please send me more reports if you find anything.
Gabor
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
