Cool... I will move these over to that
assert... And the invariant is ok since this
function only is there when you compile
invariant in.

R


On Jun 7, 2010, at 1:07 PM, Pawel Jakub Dawidek wrote:

On Sun, Jun 06, 2010 at 04:11:17PM +0000, Randall Stewart wrote:
Author: rrs
Date: Sun Jun  6 16:11:16 2010
New Revision: 208876
URL: http://svn.freebsd.org/changeset/base/208876

Log:
 1) Further enhance the INVARIANT lock validation (no locks) are
    held by checking the create and inp locks as well.
[...]
+       if (mtx_owned(&inp->inp_create_mtx)) {
+               panic("Own create lock on inp");
+       }
+       if (mtx_owned(&inp->inp_mtx)) {
+               panic("Own inp lock on inp");
+       }

If you replace this with:

        mtx_assert(&inp->inp_create_mtx, MA_NOTOWNED);
        mtx_assert(&inp->inp_mtx, MA_NOTOWNED);

But the kernel has to be compiled with INVARIANTS to make it work.

--
Pawel Jakub Dawidek                       http://www.wheelsystems.com
p...@freebsd.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

------------------------------
Randall Stewart
803-317-4952 (cell)

_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to