On Tue, Mar 16, 2010 at 10:17:22PM +0000, Kip Macy wrote: > Author: kmacy > Date: Tue Mar 16 22:17:21 2010 > New Revision: 205231 > URL: http://svn.freebsd.org/changeset/base/205231 > > Log: > - reduce contention by breaking up ARC state locks in to 16 for data > and 16 for metadata > - export L2ARC tunables as sysctls > - add several kstats to track L2ARC state more precisely > - avoid holding a contended lock when atomically incrementing a > contended counter (no lock protection needed for atomics)
Kip, don't get me wrong, I appreciate you're working on ZFS, but... I'm still working on ZFS, trying hard to bring it up-to-date and such invasive changes don't make it easier. I'm not against invasive changes in general, but I want them to be reviewed and tested properly. We discussed this multiple times and I thought the consensus was to provide hard number and workload examples that will prove the change really helps. And if it helps, present the finding to Sun/Oracle guys to get the changes into OpenSolaris, which is good for everyone: OpenSolaris gets faster ZFS, FreeBSD gets less pain in keeping ZFS up-to-date. Can I ask you to prepare description of the workload it helps, benchmark it and present the numbers on zfs-c...@opensolaris.org? The ZFS team is built from really smart and mature developers. I'm sure that if the change is properly described with prove included they will accept it and the world will be a bit better place to live for everyone. Thanks. -- Pawel Jakub Dawidek http://www.wheelsystems.com p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
pgpcfH4ROhKHD.pgp
Description: PGP signature
