Author: mav
Date: Fri Feb 26 10:42:46 2010
New Revision: 204354
URL: http://svn.freebsd.org/changeset/base/204354
Log:
Make PUIS detection more strict. Previous implementation caused false
positives on VMWare's virtual CD-ROMs.
Modified:
head/sys/cam/ata/ata_xpt.c
head/sys/sys/ata.h
Modified: head/sys/cam/ata/ata_xpt.c
==============================================================================
--- head/sys/cam/ata/ata_xpt.c Fri Feb 26 10:33:48 2010 (r204353)
+++ head/sys/cam/ata/ata_xpt.c Fri Feb 26 10:42:46 2010 (r204354)
@@ -788,11 +788,10 @@ noerror:
ata_btrim(ident_buf->serial, sizeof(ident_buf->serial));
ata_bpack(ident_buf->serial, ident_buf->serial,
sizeof(ident_buf->serial));
/* Device may need spin-up before IDENTIFY become valid. */
- if ((ident_buf->config & ATA_RESP_INCOMPLETE) ||
- ((ident_buf->support.command2 & ATA_SUPPORT_STANDBY) &&
- (ident_buf->enabled.command2 & ATA_SUPPORT_STANDBY) &&
- (ident_buf->support.command2 & ATA_SUPPORT_SPINUP) &&
- softc->spinup == 0)) {
+ if ((ident_buf->specconf == 0x37c8 ||
+ ident_buf->specconf == 0x738c) &&
+ ((ident_buf->config & ATA_RESP_INCOMPLETE) ||
+ softc->spinup == 0)) {
PROBE_SET_ACTION(softc, PROBE_SPINUP);
xpt_release_ccb(done_ccb);
xpt_schedule(periph, priority);
Modified: head/sys/sys/ata.h
==============================================================================
--- head/sys/sys/ata.h Fri Feb 26 10:33:48 2010 (r204353)
+++ head/sys/sys/ata.h Fri Feb 26 10:42:46 2010 (r204354)
@@ -51,7 +51,7 @@ struct ata_params {
#define ATA_RESP_INCOMPLETE 0x0004
/*001*/ u_int16_t cylinders; /* # of cylinders */
- u_int16_t reserved2;
+/*002*/ u_int16_t specconf; /* specific configuration */
/*003*/ u_int16_t heads; /* # heads */
u_int16_t obsolete4;
u_int16_t obsolete5;
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
