On Tue, Jan 20, 2015 at 07:59:08PM -0800, Nathan Whitehorn wrote: > > On 01/20/15 11:14, Konstantin Belousov wrote: > > On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Tue Jan 20 16:21:59 2015 > >> New Revision: 277421 > >> URL: https://svnweb.freebsd.org/changeset/base/277421 > >> > >> Log: > >> There does not seem to be any reason to acquire GIANT here. Follow amd64 > >> in removing it. > >> > >> MFC after: 1 month > >> > >> Modified: > >> head/sys/powerpc/powerpc/mem.c > >> > >> Modified: head/sys/powerpc/powerpc/mem.c > >> ============================================================================== > >> --- head/sys/powerpc/powerpc/mem.c Tue Jan 20 15:45:09 2015 > >> (r277420) > >> +++ head/sys/powerpc/powerpc/mem.c Tue Jan 20 16:21:59 2015 > >> (r277421) > >> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio, > >> cnt = 0; > >> error = 0; > >> > >> - GIANT_REQUIRED; > >> - > > This is not an acquisition, to be pedantic. Really, it is cdevsw which > > has D_NEEDGIANT flag which acquires Giant. After architectures get > > rid of GIANT_REQUIRED, flag can be removed. > > > Just so I understand, you are not objecting to this commit, right? Absolutely not, this is the right thing to do.
> Just > pointing out that (a) my commit message was wrong and that (b) once all > architectures make this change (presumably more involved) we can get rid > of the D_NEEDGIANT in /sys/dev/mem/memdev.c? Exactly. _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
