Author: ian
Date: Wed Jan 21 03:28:07 2015
New Revision: 277471
URL: https://svnweb.freebsd.org/changeset/base/277471

Log:
  Use explicit initializer style, fill in missing functions.

Modified:
  head/sys/arm/at91/at91.c
  head/sys/arm/at91/files.at91

Modified: head/sys/arm/at91/at91.c
==============================================================================
--- head/sys/arm/at91/at91.c    Wed Jan 21 03:24:18 2015        (r277470)
+++ head/sys/arm/at91/at91.c    Wed Jan 21 03:28:07 2015        (r277471)
@@ -118,110 +118,110 @@ bus_dma_get_range_nb(void)
 bs_protos(generic);
 
 struct bus_space at91_bs_tag = {
-       /* cookie */
-       (void *) 0,
+       /* privdata is whatever the implementer wants; unused in base tag */
+       .bs_privdata    = NULL,
 
        /* mapping/unmapping */
-       at91_bs_map,
-       at91_bs_unmap,
-       at91_bs_subregion,
+       .bs_map         = at91_bs_map,
+       .bs_unmap       = at91_bs_unmap,
+       .bs_subregion   = at91_bs_subregion,
 
        /* allocation/deallocation */
-       NULL,
-       NULL,
+       .bs_alloc       = generic_bs_alloc,
+       .bs_free        = generic_bs_free,
 
        /* barrier */
-       at91_barrier,
+       .bs_barrier     = at91_barrier,
 
        /* read (single) */
-       generic_bs_r_1,
-       generic_bs_r_2,
-       generic_bs_r_4,
-       NULL,
+       .bs_r_1         = NULL, /* Use inline code in bus.h */
+       .bs_r_2         = NULL, /* Use inline code in bus.h */
+       .bs_r_4         = NULL, /* Use inline code in bus.h */
+       .bs_r_8         = NULL, /* Use inline code in bus.h */
 
        /* read multiple */
-       generic_bs_rm_1,
-       generic_bs_rm_2,
-       generic_bs_rm_4,
-       NULL,
+       .bs_rm_1        = generic_bs_rm_1,
+       .bs_rm_2        = generic_bs_rm_2,
+       .bs_rm_4        = generic_bs_rm_4,
+       .bs_rm_8        = BS_UNIMPLEMENTED,
 
        /* read region */
-       generic_bs_rr_1,
-       generic_bs_rr_2,
-       generic_bs_rr_4,
-       NULL,
+       .bs_rr_1        = generic_bs_rr_1,
+       .bs_rr_2        = generic_bs_rr_2,
+       .bs_rr_4        = generic_bs_rr_4,
+       .bs_rr_8        = BS_UNIMPLEMENTED,
 
        /* write (single) */
-       generic_bs_w_1,
-       generic_bs_w_2,
-       generic_bs_w_4,
-       NULL,
+       .bs_w_1         = NULL, /* Use inline code in bus.h */
+       .bs_w_2         = NULL, /* Use inline code in bus.h */
+       .bs_w_4         = NULL, /* Use inline code in bus.h */
+       .bs_w_8         = NULL, /* Use inline code in bus.h */
 
        /* write multiple */
-       generic_bs_wm_1,
-       generic_bs_wm_2,
-       generic_bs_wm_4,
-       NULL,
+       .bs_wm_1        = generic_bs_wm_1,
+       .bs_wm_2        = generic_bs_wm_2,
+       .bs_wm_4        = generic_bs_wm_4,
+       .bs_wm_8        = BS_UNIMPLEMENTED,
 
        /* write region */
-       NULL,
-       generic_bs_wr_2,
-       generic_bs_wr_4,
-       NULL,
+       .bs_wr_1        = generic_bs_wr_1,
+       .bs_wr_2        = generic_bs_wr_2,
+       .bs_wr_4        = generic_bs_wr_4,
+       .bs_wr_8        = BS_UNIMPLEMENTED,
 
        /* set multiple */
-       NULL,
-       NULL,
-       NULL,
-       NULL,
+       .bs_sm_1        = BS_UNIMPLEMENTED,
+       .bs_sm_2        = BS_UNIMPLEMENTED,
+       .bs_sm_4        = BS_UNIMPLEMENTED,
+       .bs_sm_8        = BS_UNIMPLEMENTED,
 
        /* set region */
-       NULL,
-       generic_bs_sr_2,
-       generic_bs_sr_4,
-       NULL,
+       .bs_sr_1        = generic_bs_sr_1,
+       .bs_sr_2        = generic_bs_sr_2,
+       .bs_sr_4        = generic_bs_sr_4,
+       .bs_sr_8        = BS_UNIMPLEMENTED,
 
        /* copy */
-       NULL,
-       generic_bs_c_2,
-       NULL,
-       NULL,
-
-       /* read (single) stream */
-       generic_bs_r_1,
-       generic_bs_r_2,
-       generic_bs_r_4,
-       NULL,
+       .bs_c_1         = BS_UNIMPLEMENTED,
+       .bs_c_2         = generic_bs_c_2,
+       .bs_c_4         = BS_UNIMPLEMENTED,
+       .bs_c_8         = BS_UNIMPLEMENTED,
+
+       /* read stream (single) */
+       .bs_r_1_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_r_2_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_r_4_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_r_8_s       = NULL,   /* Use inline code in bus.h */ 
 
        /* read multiple stream */
-       generic_bs_rm_1,
-       generic_bs_rm_2,
-       generic_bs_rm_4,
-       NULL,
+       .bs_rm_1_s      = generic_bs_rm_1,
+       .bs_rm_2_s      = generic_bs_rm_2,
+       .bs_rm_4_s      = generic_bs_rm_4,
+       .bs_rm_8_s      = BS_UNIMPLEMENTED,
 
        /* read region stream */
-       generic_bs_rr_1,
-       generic_bs_rr_2,
-       generic_bs_rr_4,
-       NULL,
-
-       /* write (single) stream */
-       generic_bs_w_1,
-       generic_bs_w_2,
-       generic_bs_w_4,
-       NULL,
+       .bs_rr_1_s      = generic_bs_rr_1,
+       .bs_rr_2_s      = generic_bs_rr_2,
+       .bs_rr_4_s      = generic_bs_rr_4,
+       .bs_rr_8_s      = BS_UNIMPLEMENTED,
+
+       /* write stream (single) */
+       .bs_w_1_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_w_2_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_w_4_s       = NULL,   /* Use inline code in bus.h */ 
+       .bs_w_8_s       = NULL,   /* Use inline code in bus.h */ 
 
        /* write multiple stream */
-       generic_bs_wm_1,
-       generic_bs_wm_2,
-       generic_bs_wm_4,
-       NULL,
+       .bs_wm_1_s      = generic_bs_wm_1,
+       .bs_wm_2_s      = generic_bs_wm_2,
+       .bs_wm_4_s      = generic_bs_wm_4,
+       .bs_wm_8_s      = BS_UNIMPLEMENTED,
 
        /* write region stream */
-       NULL,
-       generic_bs_wr_2,
-       generic_bs_wr_4,
-       NULL,
+       .bs_wr_1_s      = generic_bs_wr_1,
+       .bs_wr_2_s      = generic_bs_wr_2,
+       .bs_wr_4_s      = generic_bs_wr_4,
+       .bs_wr_8_s      = BS_UNIMPLEMENTED,
 };
 
 #ifndef FDT

Modified: head/sys/arm/at91/files.at91
==============================================================================
--- head/sys/arm/at91/files.at91        Wed Jan 21 03:24:18 2015        
(r277470)
+++ head/sys/arm/at91/files.at91        Wed Jan 21 03:28:07 2015        
(r277471)
@@ -1,4 +1,5 @@
 # $FreeBSD$
+arm/arm/bus_space_generic.c    standard
 arm/arm/cpufunc_asm_arm9.S     standard
 arm/at91/at91_machdep.c                standard
 arm/at91/at91_aic.c            standard
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to