on 02/09/2014 20:43 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" <a...@freebsd.org> >> And the newly added kmem_foo() functions probably do not belong in >> cddl/compat/opensolaris as Solaris / illumos does not have those functions. > > They could be moved but their current location keeps all the kmem > related functions neatly in one place. Spreading them around IMO > would just make things hard to find.
BTW, here is some of my old WIP that completely removed the pre-existing kmem_* functions and made the related code much closer to that in illumos. Unfortunately, I will now have hard time merging my changes with your change. https://github.com/avg-I/freebsd/compare/wip/hc/kmem_size-memguard-fix (esp.commits e0cf2f7 and becf087) >> I think that in this case e.g. vm_cnt.v_free_target can just be >> used directly by the FreeBSD-specific ARC code. > > It could but as above keeping everything in one place makes it to > find and hence MFC as this area has seen changes which will require > all those fields renamed. It also means if the logic for free pages > changes in the future there's only one place it needs to be changed. > > For those interested there's also an open review on additional > changes in this area: https://reviews.freebsd.org/D702 -- Andriy Gapon _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
