On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler <ead...@freebsd.org> wrote:
> Author: eadler
> Date: Fri Feb  7 18:10:34 2014
> New Revision: 261604
> URL: http://svnweb.freebsd.org/changeset/base/261604
>
> Log:
>   HEAD is not buildable for the past day.  Commit a 'quick fix' in order to 
> permit
>   buildworld to complete.
>
>   Reviewed by:  theraven
>
> Modified:
>   head/contrib/libc++/include/locale

Are you sure that this will work on all architectures?  It implicitly
assumes that ptrdiff_t is the same as long.  IMHO, it's better to cast
the left side of the comparison to size_t, because it will always be
nonnegative as long as __a_end is greater than or equal to __a.  They
certainly sound like it, based on the names.

-Alan
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to