On 10/24/13 7:39 AM, Hilko Meyer wrote: > Andrey Zonov schrieb: >> On 10/18/13 8:38 AM, Hilko Meyer wrote: >>> On Thu, 17 Oct 2013 22:00:35 +0000 (UTC) you wrote: >>>> Author: zont >>>> Date: Thu Oct 17 22:00:35 2013 >>>> New Revision: 256710 >>>> URL: http://svnweb.freebsd.org/changeset/base/256710 >>>> >>>> Modified: >>>> head/tools/build/mk/OptionalObsoleteFiles.inc >>> >>> This fixed two files I reported in conf/167133.2. Maybe you can look for the >>> other four and close the PR. >> >> pccard.conf - is already in ObsoleteFiles.inc. >> pf.conf - we cannot just put it in ObsoleteFiles.inc because people may >> have working configuration in this place. > > Maybe put it under .if ${MK_PF} == no like > usr/share/examples/pf/pf.conf? >
I don't like this behavior. All obsolete files should be listed in ObsoleteFiles.inc, all optional files should be listed in tools/build/mk/OptionalObsoleteFiles.inc, but if file became obsolete it should be moved to ObsoleteFiles.inc. Let's declare that this file is not obsolete. I committed proposed patch as r257077, please confirm that I can close conf/167133. -- Andrey Zonov
signature.asc
Description: OpenPGP digital signature