On Tue, 2012-10-23 at 20:43:33 +0200, Michael Tuexen wrote: > On Oct 23, 2012, at 8:28 PM, Bruce Evans wrote: > > > On Tue, 23 Oct 2012, Michael Tuexen wrote: > > > >> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote: > >> > >>> On Mon, 22 Oct 2012, Xin LI wrote: > >>> > >>>> Log: > >>>> Remove __P. > >>> > >>> This was a chance to remove style bugs in the prototypes. At least it > >>> didn't create so many new ones, unlike the original __P axing. It > >>> still enlarged about a hundred by changing from Gnu style continuation > >>> to Gnu style continuation indentation with an off-by-5 error. > >> > >> please note that the SCTP code in the FreeBSD sources is generated > >> via an export script from a codebase which runs on multiple platforms. > >> The script tries to follow FreeBSDs guidelines, but is far from being > >> perfect. > > > > The export script might not like manual editing of its output. > > > > Portability might require __P(()), and then removing it cleaning requires > > a complicated script. > Maybe I wasn't clear... > > * The removal of __P() needs also be done upstream. I'll handle this, not > problem. > I don't think we need __P on any platform. > * My comment was regarding your list of formatting issues of the code. > Changing > the formatting would require changing the export script. > If someone "just" changes the FreeBSD sources and these changes are not > included > upstream, they are lost by the next commit of rrs@ or mine. > > My point was: Getting rid of __P is fine and we can handle that upstream (as > any other non whitespace/formatting changes needed), but changing the > formatting > is NOT that easy. I'm sorry about that and just wanted to let you know that > there is a reason why the style 9 stuff is not followed exactly within the > SCTP code. > > I hope this makes the situation clearer.
Maybe running it through uncrustify[1] as part of the export for FreeBSD could help here? hth Uli [1] http://uncrustify.sourceforge.net/ and textproc/uncrustify _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
