On Oct 22, 2012, at 7:40 AM, Steve Kargl wrote: > On Mon, Oct 22, 2012 at 06:59:04AM -0600, Warner Losh wrote: >> >> On Oct 21, 2012, at 10:06 PM, Steve Kargl wrote: >> >>> On Sun, Oct 21, 2012 at 09:08:49PM -0600, Warner Losh wrote: >>>> Feel free to fix them however. I added the comments because >>>> the algorithms weren't quite the same... If you have a better >>>> way, feel free to back my stuff out on the way to it. >>>> >>>> Warner >>>> >>> >>> Please back your commits out. >>> >>> Two of the three people who actually appear to be >>> working on libm have now requested the back-out. >> >> OK. While it would be just as easy for you guys to commit the new stuff >> over mine, I'll revert them. >> >> Warner >> > > Thanks. > > BTW, besides bde's technical points, your change made > our sources different from OpenBSD, NetBSD, and new > project openlibm. Diffing against the other trees > would become cluttered.
BDE's technical points vary in quality and are difficult to argue with since they are so nit-picky. :( I'd be happy to work through them, but some of the issues I just fundamentally disagree with. Since I backed out the comments, I've decided not to spend the time arguing, but do think that documenting the differences between the precisions would be good. I started down this path because I thought expf was broken because it didn't match exp exactly... However, since he's implementing a new one, wouldn't that also have diffability issues too? Warner _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"