On 16 September 2012 10:24, Tijl Coosemans <t...@coosemans.org> wrote: > On 16-09-2012 01:27, Eitan Adler wrote: >> On 15 September 2012 17:20, Bruce Cran <br...@cran.org.uk> wrote: >>> On 15/09/2012 21:57, Tijl Coosemans wrote: >>>> >>>> Freeing memory right before exiting is a waste of time. The tool shouldn't >>>> complain about it. >> >> Perhaps, but tools do. This has already been brought up on cfe-dev. >> >>> "/Stop wasting time and just exit already/." - >>> http://blogs.msdn.com/b/oldnewthing/archive/2012/01/05/10253268.aspx >> >> I read this blog post when it came out. :) > > In this case the free is actually wrong, because the pointer can point > to memory allocated by getmntinfo(3) and that manpage says an application > cannot free it.
Ah, I missed that. I wish this point was brought up earlier. I'll revert the commit -- Eitan Adler Source & Ports committer X11, Bugbusting teams _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
