Hi David; --- Ven 29/6/12, David O'Brien <obr...@freebsd.org> ha scritto: ... > ... > > +/* > > + * Copyright (c) 2011, Joyent, Inc. All rights > reserved. > > + */ > > Pedro, > It looks like you simply 'svn add'ed this file, rather than > importing it into '^/vendor/opensolaris/dist'. > Please correct me if I am wrong. >
You are absolutely right. However I am not sure we should bring Illumos enhancements under the opensolaris vendor branch. The reason is that this files are CDDL'd but are there was no property assignment done to the OpenSolaris copyright owner. [1] If somehow Oracle decides to relicense Dtrace or ZFS we still must keep these changes isolated from the code provided in the vendor branch. > We've become rather sloppy in the past 1-2 years in our > handling of 3rd-party externally developed code. Something > we need to return to our older ways good ways of handling. > Yes, that is true. I think we have to decide if we are going to consider Illumos a vendor on it's own. For ZFS it would seem the right thing to do, for Dtrace I am not sure: at least I am not considering bringing any other feature at this time. Thank you for the links on Code Provenance Review. > > Please correct this by properly importing the sources, 'svn > delete'ing the files you 'svn add'ed, and do an 'svn copy' > of the new files. > I think the discussion is indeed important enough to suspend the MFC I was planning and if desired I can also revert the commit. Pedro. [1] http://smartos.org/2011/12/15/fork-yeah-the-rise-and-development-of-illumos-2/ _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
