-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2012-06-01 14:43:49 -0400, Mitsuru IWASAKI wrote: > Hi, thanks for following up. > >> Log: Call AcpiSetFirmwareWakingVector() with interrupt disabled >> for consistency. > > Are you sure about this? Original code is like this (interrupt > ENABLED); > > ---- intr_restore(rf); > > AcpiSetFirmwareWakingVector(0); > > if (ret == 0 && mem_range_softc.mr_op != NULL && ---- > > Regarding to ACPICA source code, they said nothing about this so I > think it's not big deal. > > Just FYI, AcpiSetFirmwareWakingVector(0) was called with interrupt > enabled in Linux.
This function does not care about interrupt context. However, the first AcpiSetFirmwareWakingVector() is now called with interrupt disabled after r236403. Thus, I wanted it to be consistent as well. Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/JEWgACgkQmlay1b9qnVN+zwCfTn5zY6gmmAipPnsIgvjEK6vC 5k4AoMjdIUmRg5EuR0awEG4+uiqGCAWo =ZYNR -----END PGP SIGNATURE----- _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
