On 1 June 2012 07:24, John Baldwin <j...@freebsd.org> wrote: > This is why I personally loathe assignment side effects in boolean expressions > for control flow. I tend to write this sort of thing instead as: > > channel->dtr_arr[dtr_index].dtr = dtrh; > if (dtrh != NULL) {
Same here. I was told to use the assignment is style(9) by multiple people though. If it really is, I wish it would change. -- Eitan Adler Source & Ports committer X11, Bugbusting teams _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"