Author: jhb
Date: Thu Apr 12 13:53:49 2012
New Revision: 234182
URL: http://svn.freebsd.org/changeset/base/234182

Log:
  Don't update if_obytes when transmitting packets.  That is already done
  in IFQ_HANDOFF() when the packet is passed to the start routine, so doing
  it here resulted in double counting.
  
  Reported by:  Alex Tutubalin  lexa lexa ru
  MFC after:    1 week

Modified:
  head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c
  head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c

Modified: head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c
==============================================================================
--- head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c       Thu Apr 12 
13:53:10 2012        (r234181)
+++ head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c       Thu Apr 12 
13:53:49 2012        (r234182)
@@ -682,7 +682,6 @@ void ipoib_cm_handle_tx_wc(struct ipoib_
 
        /* FIXME: is this right? Shouldn't we only increment on success? */
        ++dev->if_opackets;
-       dev->if_obytes += tx_req->mb->m_pkthdr.len;
 
        m_freem(tx_req->mb);
 

Modified: head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c
==============================================================================
--- head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c       Thu Apr 12 
13:53:10 2012        (r234181)
+++ head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c       Thu Apr 12 
13:53:49 2012        (r234182)
@@ -345,7 +345,6 @@ static void ipoib_ib_handle_tx_wc(struct
        ipoib_dma_unmap_tx(priv->ca, tx_req);
 
        ++dev->if_opackets;
-       dev->if_obytes += tx_req->mb->m_pkthdr.len;
 
        m_freem(tx_req->mb);
 
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to