On Tue, Jan 10, 2012 at 03:52:35PM -0600, Guy Helmer wrote: > > On Jan 10, 2012, at 3:42 PM, Pawel Jakub Dawidek wrote: > > > On Tue, Jan 10, 2012 at 07:53:25PM +0000, Guy Helmer wrote: > >> Author: ghelmer > >> Date: Tue Jan 10 19:53:25 2012 > >> New Revision: 229937 > >> URL: http://svn.freebsd.org/changeset/base/229937 > >> > >> Log: > >> Add pidfile_fileno() to obtain the file descriptor for an open > >> pidfile. > > > > BTW. If you are working on pidfile, it would be nice to move pidfile > > structure declaration into pidfile.c. There is no need to expose it. > > > Is that change likely to require a "make universe" to validate?
Nice try:) No, I won't take the responsibility:) Ok, seriously. Nothing should use this structure directly. You will still need forward declaration in pidfile.h. It is not something that is arch-depended, so simple buildworld should be sufficient. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com
pgpe4acggNAI9.pgp
Description: PGP signature
