Author: yongari
Date: Sat Dec 31 01:10:29 2011
New Revision: 229059
URL: http://svn.freebsd.org/changeset/base/229059
Log:
MFC r226478:
Close a race where SIOCGIFMEDIA ioctl get inconsistent link status.
Because driver is accessing a common MII structure in
mii_pollstat(), updating user supplied structure should be done
before dropping a driver lock.
Reported by: Karim (fodillemlinkarimi <> gmail dot com)
Modified:
stable/7/sys/dev/age/if_age.c
stable/7/sys/dev/alc/if_alc.c
stable/7/sys/dev/ale/if_ale.c
stable/7/sys/dev/lge/if_lge.c
stable/7/sys/dev/msk/if_msk.c
stable/7/sys/dev/nfe/if_nfe.c
stable/7/sys/dev/nge/if_nge.c
stable/7/sys/dev/nve/if_nve.c
stable/7/sys/dev/re/if_re.c
stable/7/sys/dev/sge/if_sge.c
stable/7/sys/dev/sis/if_sis.c
stable/7/sys/dev/vge/if_vge.c
stable/7/sys/dev/vr/if_vr.c
stable/7/sys/dev/vte/if_vte.c
stable/7/sys/pci/if_rl.c
Directory Properties:
stable/7/sys/ (props changed)
stable/7/sys/cddl/contrib/opensolaris/ (props changed)
stable/7/sys/contrib/dev/acpica/ (props changed)
stable/7/sys/contrib/pf/ (props changed)
Modified: stable/7/sys/dev/age/if_age.c
==============================================================================
--- stable/7/sys/dev/age/if_age.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/age/if_age.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -282,9 +282,9 @@ age_mediastatus(struct ifnet *ifp, struc
mii = device_get_softc(sc->age_miibus);
mii_pollstat(mii);
- AGE_UNLOCK(sc);
ifmr->ifm_status = mii->mii_media_status;
ifmr->ifm_active = mii->mii_media_active;
+ AGE_UNLOCK(sc);
}
/*
Modified: stable/7/sys/dev/alc/if_alc.c
==============================================================================
--- stable/7/sys/dev/alc/if_alc.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/alc/if_alc.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -349,9 +349,9 @@ alc_mediastatus(struct ifnet *ifp, struc
mii = device_get_softc(sc->alc_miibus);
mii_pollstat(mii);
- ALC_UNLOCK(sc);
ifmr->ifm_status = mii->mii_media_status;
ifmr->ifm_active = mii->mii_media_active;
+ ALC_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/ale/if_ale.c
==============================================================================
--- stable/7/sys/dev/ale/if_ale.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/ale/if_ale.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -270,9 +270,9 @@ ale_mediastatus(struct ifnet *ifp, struc
mii = device_get_softc(sc->ale_miibus);
mii_pollstat(mii);
- ALE_UNLOCK(sc);
ifmr->ifm_status = mii->mii_media_status;
ifmr->ifm_active = mii->mii_media_active;
+ ALE_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/lge/if_lge.c
==============================================================================
--- stable/7/sys/dev/lge/if_lge.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/lge/if_lge.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -1433,9 +1433,9 @@ lge_ifmedia_sts(ifp, ifmr)
LGE_LOCK(sc);
mii = device_get_softc(sc->lge_miibus);
mii_pollstat(mii);
- LGE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ LGE_UNLOCK(sc);
return;
}
Modified: stable/7/sys/dev/msk/if_msk.c
==============================================================================
--- stable/7/sys/dev/msk/if_msk.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/msk/if_msk.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -995,9 +995,9 @@ msk_mediastatus(struct ifnet *ifp, struc
mii = device_get_softc(sc_if->msk_miibus);
mii_pollstat(mii);
- MSK_IF_UNLOCK(sc_if);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ MSK_IF_UNLOCK(sc_if);
}
static int
Modified: stable/7/sys/dev/nfe/if_nfe.c
==============================================================================
--- stable/7/sys/dev/nfe/if_nfe.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/nfe/if_nfe.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -2943,10 +2943,10 @@ nfe_ifmedia_sts(struct ifnet *ifp, struc
NFE_LOCK(sc);
mii = device_get_softc(sc->nfe_miibus);
mii_pollstat(mii);
- NFE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ NFE_UNLOCK(sc);
}
Modified: stable/7/sys/dev/nge/if_nge.c
==============================================================================
--- stable/7/sys/dev/nge/if_nge.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/nge/if_nge.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -2276,9 +2276,9 @@ nge_mediastatus(struct ifnet *ifp, struc
NGE_LOCK(sc);
mii = device_get_softc(sc->nge_miibus);
mii_pollstat(mii);
- NGE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ NGE_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/nve/if_nve.c
==============================================================================
--- stable/7/sys/dev/nve/if_nve.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/nve/if_nve.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -1203,10 +1203,10 @@ nve_ifmedia_sts(struct ifnet *ifp, struc
NVE_LOCK(sc);
mii = device_get_softc(sc->miibus);
mii_pollstat(mii);
- NVE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ NVE_UNLOCK(sc);
return;
}
Modified: stable/7/sys/dev/re/if_re.c
==============================================================================
--- stable/7/sys/dev/re/if_re.c Sat Dec 31 01:08:31 2011 (r229058)
+++ stable/7/sys/dev/re/if_re.c Sat Dec 31 01:10:29 2011 (r229059)
@@ -3208,9 +3208,9 @@ re_ifmedia_sts(struct ifnet *ifp, struct
RL_LOCK(sc);
mii_pollstat(mii);
- RL_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ RL_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/sge/if_sge.c
==============================================================================
--- stable/7/sys/dev/sge/if_sge.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/sge/if_sge.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -1746,9 +1746,9 @@ sge_ifmedia_sts(struct ifnet *ifp, struc
return;
}
mii_pollstat(mii);
- SGE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ SGE_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/sis/if_sis.c
==============================================================================
--- stable/7/sys/dev/sis/if_sis.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/sis/if_sis.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -2108,9 +2108,9 @@ sis_ifmedia_sts(struct ifnet *ifp, struc
SIS_LOCK(sc);
mii = device_get_softc(sc->sis_miibus);
mii_pollstat(mii);
- SIS_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ SIS_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/vge/if_vge.c
==============================================================================
--- stable/7/sys/dev/vge/if_vge.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/vge/if_vge.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -2174,9 +2174,9 @@ vge_ifmedia_sts(struct ifnet *ifp, struc
return;
}
mii_pollstat(mii);
- VGE_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ VGE_UNLOCK(sc);
}
static void
Modified: stable/7/sys/dev/vr/if_vr.c
==============================================================================
--- stable/7/sys/dev/vr/if_vr.c Sat Dec 31 01:08:31 2011 (r229058)
+++ stable/7/sys/dev/vr/if_vr.c Sat Dec 31 01:10:29 2011 (r229059)
@@ -2147,9 +2147,9 @@ vr_ifmedia_sts(struct ifnet *ifp, struct
return;
}
mii_pollstat(mii);
- VR_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ VR_UNLOCK(sc);
}
static int
Modified: stable/7/sys/dev/vte/if_vte.c
==============================================================================
--- stable/7/sys/dev/vte/if_vte.c Sat Dec 31 01:08:31 2011
(r229058)
+++ stable/7/sys/dev/vte/if_vte.c Sat Dec 31 01:10:29 2011
(r229059)
@@ -284,9 +284,9 @@ vte_mediastatus(struct ifnet *ifp, struc
mii = device_get_softc(sc->vte_miibus);
mii_pollstat(mii);
- VTE_UNLOCK(sc);
ifmr->ifm_status = mii->mii_media_status;
ifmr->ifm_active = mii->mii_media_active;
+ VTE_UNLOCK(sc);
}
static int
Modified: stable/7/sys/pci/if_rl.c
==============================================================================
--- stable/7/sys/pci/if_rl.c Sat Dec 31 01:08:31 2011 (r229058)
+++ stable/7/sys/pci/if_rl.c Sat Dec 31 01:10:29 2011 (r229059)
@@ -1925,9 +1925,9 @@ rl_ifmedia_sts(struct ifnet *ifp, struct
RL_LOCK(sc);
mii_pollstat(mii);
- RL_UNLOCK(sc);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ RL_UNLOCK(sc);
}
static int
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
