On Sat, Dec 17, 2011 at 09:53:56PM +0000, Bjoern A. Zeeb wrote: > > On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: > > > Author: dim > > Date: Sat Dec 17 17:21:47 2011 > > New Revision: 228650 > > URL: http://svn.freebsd.org/changeset/base/228650 > > > > Log: > > In usr.bin/netstat/atalk.c, work around a clang false positive with > > printf format warnings and conditional operators. > > > > This does not sound like a good idea. Make clang work.
Strictly speaking, clang is correct here. While the 'h' modifier is effectively a nop due to integer promotion rules, the intention is clearly "I am going to use a unsigned short here". Of course, the bug in the change is that it is using short... Joerg _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"