Hi Garrett,

* Garrett Cooper <yaneg...@gmail.com>, 20111026 09:54:
> I addressed the overall issue a bit more thoroughly via bin/143830 .
> Could you take a look at that PR and let me know what you think of it?

The patch looks okay, but I think it can be simplified. Maybe we should
get rid of all the `RESCUE' bits from the atmconfig source code itself
and add something like this to the Makefile:

.if !defined(RESCUE) && ${MK_BNSMP} != "no"
CFLAGS+= -DWITH_BSNMP
.endif

That way you can simply use `#ifdef WITH_BSNMP' throughout the source
files.

Thanks,
-- 
 Ed Schouten <e...@80386.nl>
 WWW: http://80386.nl/

Attachment: pgpwwE2PwuA68.pgp
Description: PGP signature

Reply via email to