Author: das
Date: Fri Oct 21 06:25:31 2011
New Revision: 226594
URL: http://svn.freebsd.org/changeset/base/226594

Log:
  Bugfix: feenableexcept() and fedisableexcept() should just return the
  old exception mask, not mask | ~FE_ALL_EXCEPT.
  
  MFC after:    2 weeks

Modified:
  head/lib/msun/amd64/fenv.c
  head/lib/msun/i387/fenv.c

Modified: head/lib/msun/amd64/fenv.c
==============================================================================
--- head/lib/msun/amd64/fenv.c  Fri Oct 21 05:41:20 2011        (r226593)
+++ head/lib/msun/amd64/fenv.c  Fri Oct 21 06:25:31 2011        (r226594)
@@ -135,12 +135,12 @@ __feenableexcept(int mask)
        mask &= FE_ALL_EXCEPT;
        __fnstcw(&control);
        __stmxcsr(&mxcsr);
-       omask = (control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
+       omask = ~(control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
        control &= ~mask;
        __fldcw(control);
        mxcsr &= ~(mask << _SSE_EMASK_SHIFT);
        __ldmxcsr(mxcsr);
-       return (~omask);
+       return (omask);
 }
 
 int
@@ -152,12 +152,12 @@ __fedisableexcept(int mask)
        mask &= FE_ALL_EXCEPT;
        __fnstcw(&control);
        __stmxcsr(&mxcsr);
-       omask = (control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
+       omask = ~(control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
        control |= mask;
        __fldcw(control);
        mxcsr |= mask << _SSE_EMASK_SHIFT;
        __ldmxcsr(mxcsr);
-       return (~omask);
+       return (omask);
 }
 
 __weak_reference(__feenableexcept, feenableexcept);

Modified: head/lib/msun/i387/fenv.c
==============================================================================
--- head/lib/msun/i387/fenv.c   Fri Oct 21 05:41:20 2011        (r226593)
+++ head/lib/msun/i387/fenv.c   Fri Oct 21 06:25:31 2011        (r226594)
@@ -192,14 +192,14 @@ __feenableexcept(int mask)
                __stmxcsr(&mxcsr);
        else
                mxcsr = 0;
-       omask = (control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
+       omask = ~(control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
        control &= ~mask;
        __fldcw(control);
        if (__HAS_SSE()) {
                mxcsr &= ~(mask << _SSE_EMASK_SHIFT);
                __ldmxcsr(mxcsr);
        }
-       return (~omask);
+       return (omask);
 }
 
 int
@@ -214,14 +214,14 @@ __fedisableexcept(int mask)
                __stmxcsr(&mxcsr);
        else
                mxcsr = 0;
-       omask = (control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
+       omask = ~(control | mxcsr >> _SSE_EMASK_SHIFT) & FE_ALL_EXCEPT;
        control |= mask;
        __fldcw(control);
        if (__HAS_SSE()) {
                mxcsr |= mask << _SSE_EMASK_SHIFT;
                __ldmxcsr(mxcsr);
        }
-       return (~omask);
+       return (omask);
 }
 
 __weak_reference(__feenableexcept, feenableexcept);
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to