on 20/10/2011 02:44 Pawel Jakub Dawidek said the following: > Author: pjd > Date: Wed Oct 19 23:44:38 2011 > New Revision: 226553 > URL: http://svn.freebsd.org/changeset/base/226553 > > Log: > Always pass data size for checksum verification function, as using > physical block size declared in bp may not always be what we want. > For example in case of gang block header physical block size declared > in bp is much larger than SPA_GANGBLOCKSIZE (512 bytes) and checksum > calculation failed. This bug could lead to accessing unallocated > memory and resets/failures during boot. > > MFC after: 3 days
I believe that this change is going in the wrong direction. I'd rather prefer that we decreased number of parameters :-) Se my other email. Besides I do not see where we currently really verify checksum of a re-assembled gang block. -- Andriy Gapon _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
