On Mon, 04.07.2011 at 13:24:37 +0200, Ed Schouten wrote: > Hi Uli, > > * Ulrich Spoerlein <u...@freebsd.org>, 20110701 22:45: > > - Port -Wtrampolines support from gcc3. > > Some testing here seems to suggest it's quite hard to write code that > triggers this warning, while still passing WARNS >= 3. But still, I > think it would be good to add this flag to bsd.sys.mk. > > I've run a `make universe' and it can be added to WARNS >= 2 without > breaking the build. Maybe we should add it after we have MFCd this > commit back to 8?
There are a couple of ports that are using our make and some of them
might even set WARNS, so I fear this would also need an exp-run to see
if there's any fallout there.
Otherwise, I think it's a good idea. Which WARNS<2 parts of our tree
would trigger that warning, btw?
Uli
% find . -name Makefile\* -exec grep WARNS {} +
./benchmarks/raidtest/files/Makefile:WARNS?= 6
./databases/sybtcl/files/Makefile.bsd:WARNS?= 2
./graphics/gdtclft/files/Makefile.bsd:WARNS = 2
./graphics/libfpx/files/Makefile.bsd:WARNS= 3
./graphics/libfpx/Makefile:# (based on WARNS= in particular) instead of being
influenced by
./shells/v7sh/files/Makefile:WARNS?= 6
./sysutils/ffs2recov/Makefile: WARNS=0
./sysutils/k8temp/Makefile: @${REINPLACE_CMD} -e
's|WARNS=.*[6-9]|WARNS=5|g' ${WRKSRC}/Makefile
./sysutils/k8temp/Makefile:WARNS= 6
./sysutils/lookupd/Makefile:MAKE_ENV= WARNS=0
./textproc/tclExpat/files/Makefile:WARNS= 3
./www/mod_dtcl/files/Makefile.bsd:WARNS= 2
PS: That does not include ports, using our make and setting WARNS in the
Makefile that they ship with ...
pgpDqhqgJC6KI.pgp
Description: PGP signature
