On Tue, Apr 26, 2011 at 01:44:00PM +0200, Hans Petter Selasky wrote:
> On Tuesday 26 April 2011 13:39:56 Konstantin Belousov wrote:
> > +       pending = !!callout_stop(&timeout_task->c);
> 
> pending = (callout_stop(&timeout_task->c) != 0);
> 
> ?

This line is about conversion from a boolean value to {0, 1} value set.
If !! construct does not look stylish, then wouldn't we need to go
with
        pending = (callout_stop(&timeout_task->c) != 0) ? 1 : 0;
instead ?

Feel free to adjust whatever variant you prefer and commit it.

Attachment: pgpNKu48OtZcN.pgp
Description: PGP signature

Reply via email to