Author: jfv
Date: Wed Jan 12 00:23:47 2011
New Revision: 217295
URL: http://svn.freebsd.org/changeset/base/217295

Log:
  A couple problems discovered by Andrew Boyer:
     - failure code in em_xmit got mangled along the way
       and was not properly handling errors.
     - local timer code had a leftover UNLOCK call that
       should be removed.
  
  MFC after 3 days

Modified:
  head/sys/dev/e1000/if_em.c

Modified: head/sys/dev/e1000/if_em.c
==============================================================================
--- head/sys/dev/e1000/if_em.c  Tue Jan 11 22:57:41 2011        (r217294)
+++ head/sys/dev/e1000/if_em.c  Wed Jan 12 00:23:47 2011        (r217295)
@@ -93,7 +93,7 @@ int   em_display_debug_stats = 0;
 /*********************************************************************
  *  Driver version:
  *********************************************************************/
-char em_driver_version[] = "7.1.8";
+char em_driver_version[] = "7.1.9";
 
 /*********************************************************************
  *  PCI Device ID Table
@@ -1909,14 +1909,23 @@ em_xmit(struct tx_ring *txr, struct mbuf
                error = bus_dmamap_load_mbuf_sg(txr->txtag, map,
                    *m_headp, segs, &nsegs, BUS_DMA_NOWAIT);
 
-               if (error) {
+               if (error == ENOMEM) {
+                       adapter->no_tx_dma_setup++;
+                       return (error);
+               } else if (error != 0) {
                        adapter->no_tx_dma_setup++;
                        m_freem(*m_headp);
                        *m_headp = NULL;
                        return (error);
                }
+
+       } else if (error == ENOMEM) {
+               adapter->no_tx_dma_setup++;
+               return (error);
        } else if (error != 0) {
                adapter->no_tx_dma_setup++;
+               m_freem(*m_headp);
+               *m_headp = NULL;
                return (error);
        }
 
@@ -2206,7 +2215,6 @@ hung:
            txr->me, txr->tx_avail, txr->next_to_clean);
        ifp->if_drv_flags &= ~IFF_DRV_RUNNING;
        adapter->watchdog_events++;
-       EM_TX_UNLOCK(txr);
        em_init_locked(adapter);
 }
 
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to