On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote: > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Sat Dec 25 08:42:38 2010 > > New Revision: 216694 > > URL: http://svn.freebsd.org/changeset/base/216694 > > > > Log: > > Add a hook to pass debug flags to the build of rtld when doing make in > > the rtld directory. > > > > Reviewed by: kan > > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is > working just fine for me. DEBUG_FLAGS=-g might be fine for you, but it does not do what rtld debugging needs. Look at the -DDEBUG.
If you want ${} instead of $(), feel free to change.
>
> > Modified:
> > head/libexec/rtld-elf/Makefile
> >
> > Modified: head/libexec/rtld-elf/Makefile
> > ==============================================================================
> > --- head/libexec/rtld-elf/Makefile Fri Dec 24 21:31:18 2010
> > (r216693)
> > +++ head/libexec/rtld-elf/Makefile Sat Dec 25 08:42:38 2010
> > (r216694)
> > @@ -34,7 +34,7 @@ CFLAGS+= -fPIC
> > .else
> > CFLAGS+= -fpic
> > .endif
> > -CFLAGS+= -DPIC
> > +CFLAGS+= -DPIC $(DEBUG)
> > LDFLAGS+= -shared -Wl,-Bsymbolic
> > DPADD= ${LIBC_PIC}
> > LDADD= -lc_pic -lssp_nonshared
pgpIbSYW5MlZh.pgp
Description: PGP signature
