On 6 December 2010 19:44, Pawel Jakub Dawidek <p...@freebsd.org> wrote: > On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: >> Author: ivoras >> Date: Mon Dec 6 12:18:02 2010 >> New Revision: 216230 >> URL: http://svn.freebsd.org/changeset/base/216230 >> >> Log: >> Use GEOM stripesize field when calculating ashift. This will enable correct >> alignment on drives with large sector sizes (e.g. 4 KiB) but the >> implementation might need to be revisited if devices with large stripesizes >> appear (e.g. if RAID controllers or flash drives start using the field), >> probably by introducing a physsectorsize field in GEOM providers. > > Please back this out as soon as possible!
Given information such as this: http://www.solarismen.de/archives/5-Solaris-and-the-new-4K-Sector-Disks-e.g.-WDxxEARS-Part-2.html http://article.gmane.org/gmane.os.solaris.opensolaris.zfs/43986 and my last message on the subject in the thread: http://permalink.gmane.org/gmane.os.freebsd.devel.geom/4376 Can you explain why is it wrong, and what can go wrong with changing ashift in this way? _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"