On Monday 15 November 2010 15:58:15 Bjoern A. Zeeb wrote: > On Sun, 14 Nov 2010, Dimitry Andric wrote: > > Author: dim > > Date: Sun Nov 14 20:40:55 2010 > > New Revision: 215318 > > URL: http://svn.freebsd.org/changeset/base/215318 > > > > Log: > > Instead of unconditionally emitting .globl's for the __start_set_xxx and > > __stop_set_xxx symbols, only emit them when the set_vnet or set_pcpu > > sections are actually defined. > > Unless you have a very good reason that is NOT cosmetic for this I > want to know it. None of you commit messages is giving this. > > This breaks the classic C semantics that we had gained with the former > type of macros, which is a shame. > > Kind of annoying neither of the changes had a Reviewed by: and despite > being about 2 weeks behind of most email I hadn't spotted this on arch@ > before nor seen it on virtualization@ that it obviously touches. I > would have loved to hear about them before foing to have a hard time > integrating this white space into half a year of development work. > > Looking forward to the technical explanation.
Another fundamental problem is that the commit note doesn't include a MFC plan, so if we just leave it as is, starting from now on an extremely large portion MFCs of networking code will need to be hand-adjusted. Marko > > Modified: > > head/sys/net/vnet.h > > head/sys/sys/cdefs.h > > head/sys/sys/linker_set.h > > head/sys/sys/pcpu.h _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
