On Tuesday 30 March 2010 16:26:36 Alexander Motin wrote: > Bruce Cran wrote: > > Author: brucec > > Date: Sat Mar 13 11:17:39 2010 > > New Revision: 205119 > > URL: http://svn.freebsd.org/changeset/base/205119 > > > > Log: > > Change the 'amt' parameter in format_k2 from int to unsigned long long > > to match the values passed in and prevent the SIZE field being > > corrupted when more than 2TB is allocated. > > This change seems broke top on ARM, as declaration in util.h doesn't > specifies argument type, and caller assumes int there. To make it work > correctly, second part should be done: > > --- top.prev/utils.h 2009-10-14 15:23:42.000000000 +0300 > +++ top/utils.h 2010-03-30 18:14:11.000000000 +0300 > @@ -21,4 +21,4 @@ long percentages(); > char *errmsg(); > char *format_time(); > char *format_k(); > -char *format_k2(); > +char *format_k2(unsigned long long);
Sorry, I thought things would just work since format_k2 is only ever being called with a 64-bit argument. I've committed the patch in r206056. -- Bruce Cran _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
