On Fri, 12 Mar 2010, Randall Stewart wrote:
The proper fix for the delayed SCTP checksum is to have the delayed function take an argument as to the offset to the SCTP header. This allows it to work for V4 and V6. This of course means changing all callers of the function to either pass the header len, if they have it, or create it (ip_hl << 2 or sizeof(ip6_hdr)).
It will become harder to MFC SCTP changes like this in the future, BTW. It's only good (bad) luck that this change doesn't break the KBI depended on by the ipdivert module. If SCTP had been enabled in the module (which it probably should be, with options SCTP in GENERIC), then the module would be broken, meaning that we couldn't MFC this change as-is.
After MFCing this change, I recommend fixing ipdivert, but also increased caution in changing kernel interfaces that may be depended on by modules...
Robert N M Watson Computer Laboratory University of Cambridge _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
