> > I looked at it, and at the diff of his original commit. The changes were > large enough that I don't want to assume his patch takes care of all the > issues given that patch hasn't been committed verbatim. >
The change itself is not a huge change but if you disagree, then please be specific. The current mechanism and code is broken according to the original design intention. I have a habit of not committing things or quick finger until everyone had a chance to test the patch, although I have done unit testings myself. When you say "... made the kernel toxic" and "...I don't want to assume ...", well, again, be specific instead about what you mean and give me details. The other reason I decided to postpone is because I wanted to spend more time with the PPP driver. Every other PPP interface types (if_tun, if_ng etc.) updates the if_link_state variable except PPP. > > We also have reports of the patch not working in freebsd-curr...@. > I have seen that report but it lacks detail. I have asked for more information and will investigate further as soon as it becomes available. -- Qing _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
